Without doing a line-by line compare, I do not see any obvious problems.
Usually this type of thing is due to a wiring or programming mistake.
Make a test program that sets all the lines low except for one, and make that one toggle slowly (like 1 sec on and 1 sec off). Then use your voltmeter or 'scope to confirm the correct line is toggling at the LCD's connector.
Repeat this process for each data and control line.
Once you are 100% sure every line is operating correctly and independently, if the LCD still does not come on, then there is probably a porting error or timing error.